Add StemAllometry class #306
Merged
+193
−106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #306 +/- ##
===========================================
+ Coverage 95.29% 95.77% +0.48%
===========================================
Files 28 34 +6
Lines 1720 2366 +646
===========================================
+ Hits 1639 2266 +627
- Misses 81 100 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
MarionBWeinzierl
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the
demography.t_model_functionsStemAllometry class. This bundles the allometric equations into a higher level wrapper that takes aFlora | StemTraitsinstance and a set of stem sizes as DBH.This new class then replaces the existing
Community._calculate_t_modelmethod and all of the rest of the existing code is updated to access stem allometry data through the class attributes. It also adds a simple test to confirm that the bundled allometry calculations still agree with the expected values tested on the individual functions.Fixes #305
Type of change
Key checklist
pre-commitchecks:$ pre-commit run -a$ poetry run pytestFurther checks